Editorial review: Document remaining Wasm SIMD instructions#43800
Editorial review: Document remaining Wasm SIMD instructions#43800chrisdavidmills merged 18 commits intomdn:mainfrom
Conversation
| sidebar: webassemblysidebar | ||
| --- | ||
|
|
||
| The **`add_sat_s`** [SIMD arithmetic instruction](/en-US/docs/WebAssembly/Reference/SIMD/arithmetic) performs a saturated addition of two signed [`v128`](/en-US/docs/WebAssembly/Reference/Types/v128) value interpretations. Each lane of the output value is the result of adding the corresponding lanes of the input value. |
There was a problem hiding this comment.
Not reviewing yet of course, but saw this term "saturated addition". I know this is probably known by the intended audience but I have never heard of this, and think it reasonable to be a wikipedia link
There was a problem hiding this comment.
Edit note, if "Each lane of the output value is the result of adding the corresponding lanes of the input value." is all this means, I still wonder what "saturated" means. Probably not a wikipedia link if you can explain it here.
There was a problem hiding this comment.
Good point. I've both linked to the relevant Wikipedia entry on the relevant pages and explained what the output values are clamped to due to the saturation.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Some SIMD fixes
|
The tech review PR is merged (thanks, @eqrion!) Over to you, @hamishwillee. Let me know if you can spot anything else that needs urgent attention before we get it merged. |
hamishwillee
left a comment
There was a problem hiding this comment.
Looks pretty good. I have scanned this and tried to look at each type of function, but not necessarily each function in detail. Patterns are common, so if you take the suggestions in one you can roll them out to the similar methods.
hamishwillee
left a comment
There was a problem hiding this comment.
@chrisdavidmills Looks good. Just one comment to address https://github.com/mdn/content/pull/43800/changes/05cc6057b0b63a6b93052b648b8a17187cbecd5e..4de01b5317d01d470d6ef2ccf998ed0254ac6605#r3114060720
I'm approving so I don't block you after you have looked at that.
Description
This PR (hopefully!) documents all of the remaining Wasm SIMD instructions that were not covered in other PRs.
Motivation
Additional details
Related issues and pull requests