Skip to content

fix: remove unsafe exec() in MMSocketClientItem.cpp#3

Open
orbisai0security wants to merge 1 commit into
miaomiaoyule:mainfrom
orbisai0security:fix-v-002-websocket-memcpy-bounds-check
Open

fix: remove unsafe exec() in MMSocketClientItem.cpp#3
orbisai0security wants to merge 1 commit into
miaomiaoyule:mainfrom
orbisai0security:fix-v-002-websocket-memcpy-bounds-check

Conversation

@orbisai0security

Copy link
Copy Markdown

Summary

Fix critical severity security issue in MMHelper/MMSocket/SocketServer/MMSocketClientItem.cpp.

Vulnerability

Field Value
ID V-002
Severity CRITICAL
Scanner multi_agent_ai
Rule V-002
File MMHelper/MMSocket/SocketServer/MMSocketClientItem.cpp:561

Description: The WebSocket frame parser performs four memcpy operations using length values derived directly from the incoming network frame header without validating that the source buffer contains sufficient data or that the destination buffer has adequate capacity. An unauthenticated remote attacker can send a malformed WebSocket frame with manipulated length fields to trigger out-of-bounds reads or writes, corrupting heap memory and potentially achieving remote code execution.

Changes

  • MMHelper/MMSocket/SocketServer/MMSocketClientItem.cpp

Verification

  • Build passes
  • Scanner re-scan confirms fix
  • LLM code review passed

Automated security fix by OrbisAI Security

Automated security fix generated by Orbis Security AI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant