Skip to content

refactor: Export isFinalId from id-compressor internally and reference it in SharedTree#27306

Open
Abe27342 wants to merge 2 commits into
microsoft:mainfrom
Abe27342:internal-expose-isFinalId
Open

refactor: Export isFinalId from id-compressor internally and reference it in SharedTree#27306
Abe27342 wants to merge 2 commits into
microsoft:mainfrom
Abe27342:internal-expose-isFinalId

Conversation

@Abe27342
Copy link
Copy Markdown
Contributor

Description

Replaces explicit checks against 0 for short ids with isFinalId, exporting it from the /internal entrypoint.

Copilot AI review requested due to automatic review settings May 13, 2026 18:50
@Abe27342 Abe27342 requested review from a team as code owners May 13, 2026 18:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Exports isFinalId from the id-compressor /internal entrypoint and replaces inline >= 0 / < 0 checks in SharedTree with it for clarity.

Changes:

  • Export isFinalId from id-compressor /internal and add @internal + @privateRemarks docs.
  • Replace explicit short-id sign checks with isFinalId calls in SharedTree codecs.
  • Remove related TODO comments.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/runtime/id-compressor/src/index.ts Re-exports isFinalId.
packages/runtime/id-compressor/src/identifiers.ts Adds @internal and explanatory privateRemarks to isFinalId.
packages/dds/tree/src/feature-libraries/chunked-forest/codec/nodeEncoder.ts Uses isFinalId for narrowing.
packages/dds/tree/src/feature-libraries/chunked-forest/codec/chunkDecoding.ts Uses isFinalId on stream value.
packages/dds/tree/src/core/tree/detachedFieldIndexCodecV2.ts Replaces sign checks with isFinalId.
packages/dds/tree/src/core/tree/detachedFieldIndexCodecV1.ts Replaces sign checks with isFinalId.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (36 lines, 6 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants