Add outline to stream overlay text#1887
Open
mira-x wants to merge 2 commits into
Open
Conversation
This SIGSEGV occurred when closing the stats overlay and then re-opening it after a while. When no overlay text was present yet, it crashed the whole app.
mwd102
pushed a commit
to mwd102/moonlight-qt
that referenced
this pull request
Jun 20, 2026
Upstream PR: moonlight-stream#1887 Original-author: @mira-x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this fixes issue #1877.
Although that issue suggest using text shadows, I figured that drawing an outline is simpler and equally effective. I settled for an outline of 4px width. Thinner outlines were okay on 1080p screens, but only marginally improved legibility on my 43" 4K display.
I also noticed that there is a similar PR #1606 which solves this issue by putting a transparent black box behind all the text. However, that box is larger than the text itself, which unneccessarily hinders visibility where there is no text.
Below are some screenshots. The thumbnails are not that legible, so you should look at them in fullscreen to get a sense of how a user will perceive the outline.
1080p (The statistics show it's a 4K stream, but it's played back on a 1080p screen):
4K:
I look forward to hearing from you soon :)