Skip to content

fix(android): annotate classes with @Keep + @DoNotStrip to prevent RC8 stripping them#3825

Closed
DaveyEke wants to merge 1 commit into
mrousavy:mainfrom
DaveyEke:fix/add-missing-annotations
Closed

fix(android): annotate classes with @Keep + @DoNotStrip to prevent RC8 stripping them#3825
DaveyEke wants to merge 1 commit into
mrousavy:mainfrom
DaveyEke:fix/add-missing-annotations

Conversation

@DaveyEke

Copy link
Copy Markdown

No description provided.

@vercel

vercel Bot commented Apr 29, 2026

Copy link
Copy Markdown

@DaveyEke is attempting to deploy a commit to the Margelo Team on Vercel.

A member of the Team first needs to authorize it.

*/
@SuppressLint("RestrictedApi")
@Keep
@DoNotStrip

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed since the object is not autolinked - it would be unnecessary.

*/
@SuppressLint("RestrictedApi")
@Keep
@DoNotStrip

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

import com.margelo.nitro.camera.public.NativeCameraExtension

@Keep
@DoNotStrip

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@mrousavy

mrousavy commented May 5, 2026

Copy link
Copy Markdown
Owner

I think #3835 fixed this now, but let me know if there still is a crash in release

@mrousavy mrousavy closed this May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants