docs(dav): correct Node::touch docblock and add property promotion#58698
Open
joshtrichards wants to merge 2 commits into
Open
docs(dav): correct Node::touch docblock and add property promotion#58698joshtrichards wants to merge 2 commits into
Node::touch docblock and add property promotion#58698joshtrichards wants to merge 2 commits into
Conversation
joshtrichards
requested review from
Altahrim,
ArtificialOwl,
icewind1991 and
sorbaugh
and removed request for
a team
joshtrichards
added
feature: dav
♻️ refactor
Merged
Closed
joshtrichards
changed the title
Node::touch docblock and add property promotion
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
force-pushed
the
jtr/docs-sabre-node-touch-docblock-fix
branch
from
cd0f385 to
0714e2a
Compare
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
Node::touch()docblock to match the implementation (instead of describing non-existent parameters) and promotesFileInfoto a constructor property.Checklist
3. to review, feature component)stable32)AI (if applicable)