Skip to content

chore: Improve warning message in SetConfig command#60064

Open
CarrotManMatt wants to merge 1 commit intonextcloud:masterfrom
CarrotManMatt:patch-1
Open

chore: Improve warning message in SetConfig command#60064
CarrotManMatt wants to merge 1 commit intonextcloud:masterfrom
CarrotManMatt:patch-1

Conversation

@CarrotManMatt
Copy link
Copy Markdown

@CarrotManMatt CarrotManMatt commented May 2, 2026

Summary

Fixes a spelling mistake in the log message shown to administrators when updating a config value in such a way that could cause breakages.

Checklist

No AI Disclosure

  • No AI was used in creating the content of this PR

@CarrotManMatt CarrotManMatt requested a review from a team as a code owner May 2, 2026 11:42
@CarrotManMatt CarrotManMatt requested review from ArtificialOwl, icewind1991, leftybournes and salmart-dev and removed request for a team May 2, 2026 11:42
@susnux susnux added bug 3. to review Waiting for reviews labels May 2, 2026
@susnux susnux added this to the Nextcloud 34 milestone May 2, 2026
Copy link
Copy Markdown
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Maybe we can tighten up the overall message while we're here

The commit message needs to be conventional style too or it won't pass tests. Please edit it.

Comment thread core/Command/Config/App/SetConfig.php Outdated
Signed-off-by: Matt Norton <matt@carrotmanmatt.com>
@CarrotManMatt CarrotManMatt changed the title Fix set config message typo chore: Improve warning message in SetConfig command May 5, 2026
@CarrotManMatt
Copy link
Copy Markdown
Author

Many thanks for the suggestions @joshtrichards! I admit I'm not too well-versed in the correct "conventional style" for commit messages so have marked it as chore:. If this is wrong and it should be fix: or something else, let me know and I can change it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants