feat(ContactsInteraction): Allow write-properties to support sort favorites feature#60183
Closed
DerDreschner wants to merge 1 commit intomasterfrom
Closed
feat(ContactsInteraction): Allow write-properties to support sort favorites feature#60183DerDreschner wants to merge 1 commit intomasterfrom
DerDreschner wants to merge 1 commit intomasterfrom
Conversation
…orites feature Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
kesselb
approved these changes
May 6, 2026
Contributor
|
Fine by me. I would like to mention that those contacts are automatically deleted when you did not interact with them in the last 7 days1 and hence its a bit weird to favorite them? Footnotes |
Contributor
Author
|
Hmm, good point... @ChristophWurst: Should we allow that case or not? @GretaD had some code in that checked for that, but on the wrong ACL property (address book modifyable or not instead of write-properties). |
Member
|
Given how volatile the data is I wouldn't allow fav'ing or any other property. Let's have a check for that ACL in the frontend and exclude them. |
Contributor
Author
|
@GretaD: Do you need any changes in the backend for that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Right now, the automatically added
Recently contactedaddress book only allows read requests. That's insufficient for the favorite contacts feature, as we need to allowwrite-propertieshere as well. There are no additional changes necessary, as the properties are automatically being written to theoc_propertiestable.Refs nextcloud/contacts#105
Checklist
3. to review, feature component)stable32)AI (if applicable)