Skip to content

feat(ContactsInteraction): Allow write-properties to support sort favorites feature#60183

Closed
DerDreschner wants to merge 1 commit intomasterfrom
feat/allow-write-properties-for-recent-contacted
Closed

feat(ContactsInteraction): Allow write-properties to support sort favorites feature#60183
DerDreschner wants to merge 1 commit intomasterfrom
feat/allow-write-properties-for-recent-contacted

Conversation

@DerDreschner
Copy link
Copy Markdown
Contributor

Summary

Right now, the automatically added Recently contacted address book only allows read requests. That's insufficient for the favorite contacts feature, as we need to allow write-properties here as well. There are no additional changes necessary, as the properties are automatically being written to the oc_properties table.

Refs nextcloud/contacts#105

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

…orites feature

Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
@DerDreschner DerDreschner added this to the Nextcloud 34 milestone May 6, 2026
@DerDreschner DerDreschner added 3. to review Waiting for reviews feature: carddav Related to CardDAV internals labels May 6, 2026
@kesselb
Copy link
Copy Markdown
Contributor

kesselb commented May 6, 2026

Fine by me.

I would like to mention that those contacts are automatically deleted when you did not interact with them in the last 7 days1 and hence its a bit weird to favorite them?

Footnotes

  1. https://github.com/nextcloud/server/blob/d56ad83c1cad5786c098b3be0210e38b94325a2c/apps/contactsinteraction/lib/Db/RecentContactMapper.php#L106-L114

@DerDreschner
Copy link
Copy Markdown
Contributor Author

Hmm, good point... @ChristophWurst: Should we allow that case or not? @GretaD had some code in that checked for that, but on the wrong ACL property (address book modifyable or not instead of write-properties).

@ChristophWurst
Copy link
Copy Markdown
Member

Given how volatile the data is I wouldn't allow fav'ing or any other property.

Let's have a check for that ACL in the frontend and exclude them.

@DerDreschner
Copy link
Copy Markdown
Contributor Author

@GretaD: Do you need any changes in the backend for that?

@ChristophWurst ChristophWurst deleted the feat/allow-write-properties-for-recent-contacted branch May 6, 2026 13:44
@DerDreschner DerDreschner removed this from the Nextcloud 34 milestone May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: carddav Related to CardDAV internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants