Fix error when creating mail shares if custom tokens are enabled#60378
Draft
danxuliu wants to merge 1 commit into
Draft
Fix error when creating mail shares if custom tokens are enabled#60378danxuliu wants to merge 1 commit into
danxuliu wants to merge 1 commit into
Conversation
Member
Author
|
/backport to stable33 please |
Member
Author
|
/backport to stable32 please |
When a new share is saved it is first created in the backend and then updated with some additional attributes set in the frontend. If custom tokens are enabled the attributes to update also include the token. However, for new shares the token is set by the backend when it is created, it is not defined by the frontend, so the token returned by the backend needs to be copied to the share data in the frontend. Otherwise the update would fail because an empty token is sent. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
fix-error-when-creating-mail-shares-if-custom-tokens-are-enabled
branch
from
148ddb0 to
77a8bc7
Compare
Member
Author
Contributor
Add it to the baseline. There is no proper fix as the whole app needs to refactored to never mutate props. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56168
When a new share is saved it is first created in the backend and then updated with some additional attributes set in the frontend. If custom tokens are enabled the attributes to update also include the token. However, for new shares the token is set by the backend when it is created, it is not defined by the frontend, so the token returned by the backend needs to be copied to the share data in the frontend. Otherwise the update would fail because an empty token is sent.
Note that this is unrelated to #53442, which is about not being able to modify the token of a mail share because the backend does not store the new one.
How to test
Allow users to set custom share link tokensResult with this pull request
The share is created without errors; modifying it (for example, to change the permissions) also works without errors
Result without this pull request
The share is created, but
Tokens must contain at least 1 character and may only contain letters, numbers, or a hyphenis shown in an error toast; trying to modify the share will also cause the same error to appear, although it does not appear once the page is reloaded and the share is modified again (as in that case the token was already loaded from the backend when opening the share details).