-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fixes #27842: Fix unitycataog error when httpPath is missing #27844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mohittilala
merged 3 commits into
main
from
fix/unitycatalog-no-httppath-connection-args
May 1, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
ingestion/tests/unit/topology/database/test_unity_catalog_connection.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| # Copyright 2025 Collate | ||
| # Licensed under the Collate Community License, Version 1.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # https://github.com/open-metadata/OpenMetadata/blob/main/ingestion/LICENSE | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """ | ||
| Tests for unitycatalog.connection.get_sqlalchemy_connection. | ||
| """ | ||
|
|
||
| from sqlalchemy.engine import Engine | ||
|
|
||
| from metadata.generated.schema.entity.services.connections.database.databricks.personalAccessToken import ( | ||
| PersonalAccessToken, | ||
| ) | ||
| from metadata.generated.schema.entity.services.connections.database.unityCatalogConnection import ( | ||
| UnityCatalogConnection, | ||
| ) | ||
| from metadata.ingestion.source.database.unitycatalog.connection import ( | ||
| get_sqlalchemy_connection, | ||
| ) | ||
|
|
||
|
|
||
| def _connection(**overrides) -> UnityCatalogConnection: | ||
| defaults = { | ||
| "hostPort": "test-host:443", | ||
| "authType": PersonalAccessToken(token="test-token"), | ||
| } | ||
| defaults.update(overrides) | ||
| return UnityCatalogConnection(**defaults) | ||
|
|
||
|
|
||
| def test_returns_engine_when_http_path_and_connection_args_are_unset(): | ||
| """ | ||
| Regression for the AttributeError raised on | ||
| `connection.connectionArguments.root.update(auth_args)` when both | ||
| httpPath and connectionArguments are omitted from the service config. | ||
| """ | ||
| connection = _connection() | ||
| assert connection.httpPath is None | ||
| assert connection.connectionArguments is None | ||
|
|
||
| engine = get_sqlalchemy_connection(connection) | ||
|
|
||
| assert isinstance(engine, Engine) | ||
|
mohittilala marked this conversation as resolved.
|
||
|
|
||
|
|
||
| def test_returns_engine_when_http_path_is_set(): | ||
| """Engine is created and http_path is accepted as a connect arg.""" | ||
| connection = _connection(httpPath="/sql/1.0/warehouses/abc") | ||
|
|
||
| engine = get_sqlalchemy_connection(connection) | ||
|
|
||
| assert isinstance(engine, Engine) | ||
| assert engine.url.host == "test-host" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.