chore: Added devcontainer for local development#3383
chore: Added devcontainer for local development#3383vqrf wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3383 +/- ##
=====================================
Coverage 82.2% 82.2%
=====================================
Files 128 128
Lines 24626 24626
=====================================
Hits 20267 20267
Misses 4359 4359 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| }, | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/rust:1": { | ||
| "version": "1.93", |
There was a problem hiding this comment.
I think latest would probably be better? Otherwise we will be chasing our tails here
|
We should reference this in CONTRIBUTING.md too, somewhere around here - if you prefer, you can get started quickly with a complete devcontainers setup! opentelemetry-rust/CONTRIBUTING.md Lines 56 to 59 in 146376f |
|
I tried this out! It seems like we've got all the deps we need, but the "open in devcontainer" experience on my desktop (colima & docker, Mac) OOMs on build and test, in particular running the linker: The VM itself is setup with 2 GiB of RAM which I think is fairly typical. I have tried using I think if we use devcontainers they should optimally just work as that's a big part of the sell, but i'm not sure there is a way to advertise to the OS/container engine that you need X GiB of RAM. Any ideas @vqrf ? |
Changes
Added
devcontainerfor local development.Notes
Devcontainer capabilities:
docker in docker, withmobydisabled (not present indebian 13)Rust1.93withrust-analyzer,rust-src,rustfmt,clippy,rust-docsJustification
Use new popular way to develop code with easy and reproducible environment for everyone.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes