feat(metrics): add OTEL_EXPORTER_OTLP_METRICS_DEFAULT_HISTOGRAM_AGGREGATION support#3433
Open
michaelbeaumont wants to merge 6 commits intoopen-telemetry:mainfrom
Open
Conversation
63d5007 to
0177db9
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3433 +/- ##
=======================================
- Coverage 83.7% 83.6% -0.1%
=======================================
Files 126 126
Lines 25386 25561 +175
=======================================
+ Hits 21255 21380 +125
- Misses 4131 4181 +50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0177db9 to
35d1bdc
Compare
35d1bdc to
8a440a4
Compare
cijothomas
reviewed
Apr 28, 2026
| fn temporality(&self) -> Temporality; | ||
|
|
||
| /// The default aggregation to use for histogram instruments. | ||
| fn default_histogram_aggregation(&self) -> HistogramAggregation; |
Member
There was a problem hiding this comment.
give default implementation, else this is a breaking change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3374:
Changes
Add support for resolving
OTEL_EXPORTER_OTLP_METRICS_DEFAULT_HISTOGRAM_AGGREGATIONfrom the environment and threading it into exporters.This adds a new method to the traits. If this is a problem it can certainly be replaced with a default implementation.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes