Skip to content

feat: add oxlint configuration and update dependencies#126

Open
rubiin wants to merge 3 commits intomainfrom
oxlint
Open

feat: add oxlint configuration and update dependencies#126
rubiin wants to merge 3 commits intomainfrom
oxlint

Conversation

@rubiin
Copy link
Copy Markdown
Member

@rubiin rubiin commented Apr 15, 2026

Description

Adds oxlint for linting

Related Issue

[If your pull request is related to an existing issue, reference it here using the format "Fixes #issue_number".]

Type of Change

Please mark the appropriate option below to describe the type of change your pull request introduces:

  • Bug fix
  • New feature
  • Enhancement
  • Documentation update
  • Refactor
  • Other (please specify)

Checklist

  • I have added/updated the necessary documentation on README.md.
  • I have added appropriate test cases (if applicable) to ensure the changes are functioning correctly.
  • My pull request has a clear title and description.

Additional Notes

[Add any additional notes or context that you think the reviewers should know about.]

By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.

@rubiin rubiin requested review from aj3sh and sugat009 and removed request for sugat009 April 15, 2026 11:22
@rubiin
Copy link
Copy Markdown
Member Author

rubiin commented Apr 15, 2026

Additionally we could add it to the CI as a step

@aj3sh
Copy link
Copy Markdown
Member

aj3sh commented Apr 17, 2026

What went wrong with eslint? Why oxlint is necessary? And why multiple linters?

Could you please provide more details of the PR on the PR description.

@rubiin
Copy link
Copy Markdown
Member Author

rubiin commented Apr 17, 2026

Eslint is slow in cases and the changes from one major semvar to another is a nightmare. Oxlint is a high-performance JavaScript/TypeScript linter designed to replace ESLint, offering significant speed improvements (50-100x faster) by being built in Rust. Also oxlint is eslint compatible,
You could read more on here https://oxc.rs/docs/guide/usage/linter.html

Copy link
Copy Markdown
Contributor

@sugat009 sugat009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

issue (blocking): CI is failing — oxlint.config.ts was not formatted with Prettier

The Prettier check step fails because the config file has formatting issues. Run npx prettier --write oxlint.config.ts before pushing.

suggestion: consider adding CI integration in this PR as well — it is a small change and would ship oxlint as a complete, usable setup. Either a dedicated CI step or updating the lint script (e.g. "lint": "prettier --check . && oxlint") would work.

Comment thread package.json
Comment thread oxlint.config.ts Outdated
Comment thread oxlint.config.ts Outdated
Comment thread oxlint.config.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants