Improve Secret redaction for config File Logging#7560
Merged
tkalvas merged 1 commit intoopentripplanner:dev-2.xfrom May 5, 2026
Merged
Improve Secret redaction for config File Logging#7560tkalvas merged 1 commit intoopentripplanner:dev-2.xfrom
tkalvas merged 1 commit intoopentripplanner:dev-2.xfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7560 +/- ##
==========================================
Coverage 72.41% 72.41%
- Complexity 21183 21187 +4
==========================================
Files 2366 2367 +1
Lines 86237 86241 +4
Branches 8490 8492 +2
==========================================
+ Hits 62446 62451 +5
+ Misses 20795 20794 -1
Partials 2996 2996 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ass and handle `JsonArrays` during redaction
85a6ea3 to
4f43431
Compare
jessicaKoehnke
approved these changes
Apr 29, 2026
tkalvas
approved these changes
May 5, 2026
t2gran
pushed a commit
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some Secrets in config files were not redacted during logging, this PR aims to fix this.
Issue
Some Secrets in config files were not redacted during logging, this had 2 causes:
passwordwas not included in the REDACT_KEYS List but used in the updaterconfig for SIRI-ET via MQTTJsonArrayswere completely ignored during the recursive search for redactable keys, butJsonArraysare used for configuring the updaters.I have fixed both issues.
Unit tests
ConfigFileRedactorfor better TestabilityConfigFileRedactorTestDocumentation
Not needed for bugfix