Skip to content

Revert exception thrown when encountering negative A* weight#7572

Closed
leonardehrenfried wants to merge 1 commit into
opentripplanner:dev-2.xfrom
leonardehrenfried:revert-error-message
Closed

Revert exception thrown when encountering negative A* weight#7572
leonardehrenfried wants to merge 1 commit into
opentripplanner:dev-2.xfrom
leonardehrenfried:revert-error-message

Conversation

@leonardehrenfried
Copy link
Copy Markdown
Member

Summary

@vpaturet has reported that the Norwegian graph build fails because I made the A* code throw an exception instead of logging a warning in #7519.

This PR reverts to a log message instead of an exception.

I will fix the problem at the root in a follow up.

Issue

Relates to #7570

Unit tests

Updated.

@leonardehrenfried leonardehrenfried requested a review from a team as a code owner April 29, 2026 14:57
@leonardehrenfried leonardehrenfried added the !Bug Apply to issues describing a bug and PRs witch fixes it. label Apr 29, 2026
@vpaturet vpaturet added the Entur Test This is currently being tested at Entur label Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.42%. Comparing base (3970345) to head (b0d31ef).
⚠️ Report is 2 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...entripplanner/street/search/state/StateEditor.java 44.44% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #7572   +/-   ##
==========================================
  Coverage      72.42%   72.42%           
- Complexity     21192    21194    +2     
==========================================
  Files           2370     2370           
  Lines          86300    86306    +6     
  Branches        8485     8485           
==========================================
+ Hits           62501    62507    +6     
- Misses         20803    20806    +3     
+ Partials        2996     2993    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

!Bug Apply to issues describing a bug and PRs witch fixes it. Entur Test This is currently being tested at Entur

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants