Revert exception thrown when encountering negative A* weight#7572
Closed
leonardehrenfried wants to merge 1 commit into
Closed
Revert exception thrown when encountering negative A* weight#7572leonardehrenfried wants to merge 1 commit into
leonardehrenfried wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #7572 +/- ##
==========================================
Coverage 72.42% 72.42%
- Complexity 21192 21194 +2
==========================================
Files 2370 2370
Lines 86300 86306 +6
Branches 8485 8485
==========================================
+ Hits 62501 62507 +6
- Misses 20803 20806 +3
+ Partials 2996 2993 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
habrahamsson-skanetrafiken
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@vpaturet has reported that the Norwegian graph build fails because I made the A* code throw an exception instead of logging a warning in #7519.
This PR reverts to a log message instead of an exception.
I will fix the problem at the root in a follow up.
Issue
Relates to #7570
Unit tests
Updated.