Remove subprojects#1022
Draft
kelson42 wants to merge 1 commit into
Draft
Conversation
fc7bf38 to
8fb78f0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1022 +/- ##
=======================================
Coverage 56.39% 56.39%
=======================================
Files 100 100
Lines 5050 5050
Branches 2241 2241
=======================================
Hits 2848 2848
Misses 728 728
Partials 1474 1474 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
8fb78f0 to
5f00499
Compare
5f00499 to
90cbb6d
Compare
Contributor
Author
|
@veloman-yunkan To me it looks like the kiwix-build CI does not provide the libzma headers and binaries, therefore it fails to compile here on Windows. Would you be able please to confirm? |
90cbb6d to
18cfd68
Compare
Collaborator
Confirming. kiwix/kiwix-build@d8b4d24?w=1 didn't include |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meson subprojects adds a new level of compilation dependencies which makes the overall dependencies understanding even more difficult to understand.
We, at Kiwix, already track the dependencies at kiwix-build level and that should be the unique way to impact the CI/CD compilation of libzim.
For external developers, it has been also usually advocate that the meson subprojects make the life of developers easier. But I think at the end: