Skip to content

Remove subprojects#1022

Draft
kelson42 wants to merge 1 commit into
mainfrom
remove-subprojects
Draft

Remove subprojects#1022
kelson42 wants to merge 1 commit into
mainfrom
remove-subprojects

Conversation

@kelson42

@kelson42 kelson42 commented Dec 13, 2025

Copy link
Copy Markdown
Contributor

Meson subprojects adds a new level of compilation dependencies which makes the overall dependencies understanding even more difficult to understand.

We, at Kiwix, already track the dependencies at kiwix-build level and that should be the unique way to impact the CI/CD compilation of libzim.

For external developers, it has been also usually advocate that the meson subprojects make the life of developers easier. But I think at the end:

  • Developers should be able to handle the dependencies anyway
  • At the end if complexifies the undestanding because we have an additional level (to the usual local and system libraries)

@kelson42 kelson42 added this to the 9.5.0 milestone Dec 13, 2025
@codecov

codecov Bot commented Dec 13, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.39%. Comparing base (7c69234) to head (18cfd68).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1022   +/-   ##
=======================================
  Coverage   56.39%   56.39%           
=======================================
  Files         100      100           
  Lines        5050     5050           
  Branches     2241     2241           
=======================================
  Hits         2848     2848           
  Misses        728      728           
  Partials     1474     1474           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kelson42 kelson42 modified the milestones: 9.5.0, 9.6.0 Feb 6, 2026
@kelson42 kelson42 modified the milestones: 9.6.0, 9.7.0 Apr 2, 2026
@kelson42 kelson42 modified the milestones: 9.7.0, 9.8.0 May 9, 2026
@kelson42 kelson42 force-pushed the remove-subprojects branch from 5f00499 to 90cbb6d Compare June 2, 2026 15:00
@kelson42

kelson42 commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

@veloman-yunkan To me it looks like the kiwix-build CI does not provide the libzma headers and binaries, therefore it fails to compile here on Windows. Would you be able please to confirm?

@kelson42 kelson42 requested a review from veloman-yunkan June 2, 2026 15:21
@kelson42 kelson42 force-pushed the remove-subprojects branch from 90cbb6d to 18cfd68 Compare June 5, 2026 16:36
@kelson42 kelson42 modified the milestones: 9.8.0, 9.9.0 Jun 5, 2026
@veloman-yunkan

Copy link
Copy Markdown
Collaborator

@veloman-yunkan To me it looks like the kiwix-build CI does not provide the libzma headers and binaries, therefore it fails to compile here on Windows. Would you be able please to confirm?

Confirming. kiwix/kiwix-build@d8b4d24?w=1 didn't include lzma in the list of base dependencies under Windows and it has stayed like that since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants