feat(static): make symbols sortable by name or address#99
feat(static): make symbols sortable by name or address#99XXMA16 wants to merge 1 commit intoorhun:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
========================================
- Coverage 3.30% 3.25% -0.04%
========================================
Files 19 19
Lines 2426 2462 +36
========================================
Hits 80 80
- Misses 2346 2382 +36 ☔ View full report in Codecov by Sentry. |
|
Looks good to me! Thanks for implementing! <3 Can we also use lowercase
Sounds good. I'm curious how a trait would look like though. What is in your mind?
Yup, sounds good. Feel free to make the refactor.
Would be nice to disable that somehow. |
076ba39 to
311261d
Compare
Description of change
Made the Symbols from Static Analysis sortable by name and address. The sorting modes can be cycled with
S.Concerns
Should I make a
Sorttrait in order to have less repeated code?Should
info_indexbe bound to Static Analysis instead of State?The option to sort is shown for
DynamicandRelocationstoo, even though it doesn't do anything.partially closes #22