fix exit code in non-interactive mode#1011
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
ouch decompresshits a file or directory conflict and stdin is /dev/null e.g. when used in a script, it cannot prompt the user.The default of FileConflitOperation is Cancel, which makes the entry silently skip and the whole run report success (exit 0) while extracting nothing.
This is also inconsistent with an empty-pipe (EOF) stdin, which already returns a FinalError and exits non-zero for the very same prompt.
This PR makes the behavior consistent and returns an error when the conflict is detected while running non interactively