Improving performancy by reducing creation of std::locale objects and use of std::locale::global#135
Open
ytterx wants to merge 2 commits intop-ranav:masterfrom
Open
Improving performancy by reducing creation of std::locale objects and use of std::locale::global#135ytterx wants to merge 2 commits intop-ranav:masterfrom
ytterx wants to merge 2 commits intop-ranav:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During performance testing where a lot of calls to tabulate where done, we noticed that a lot of time was spent in the creation of
std::localeobjects.Instead of storing
std::stringwe store astd::localeobject to prevent the on-the-fly creation of these objects.Also
std::local::globalshould be avoided if possible (#114), using.imbueon theostreamdirectly instead.This change expands on #126
I also slightly modified the fix done in #110 (actually done in #119? 110 can also be closed) by moving the setting of the locale to be done later then the check (no need to first get the locale, if we're returning early..)