Document panics in public API#1174
Conversation
Document panics in: - Position::line_of() - panics on out-of-bounds position - ParserState::stack_peek() - panics on empty stack - ParserState::stack_pop() - panics on empty stack
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughRustdoc-only update adding ChangesPanic Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Warning |
Add missing
# Panicssections to:Position::line_of()- panics when position is out of boundsParserState::stack_peek()- panics when called on empty stackParserState::stack_pop()- panics when called on empty stackPosition::Ord::cmp()- panics when comparing positions from different input stringsFixes #999
---Payment info---
PayPal: n6085530@gmail.com
Summary by CodeRabbit