Add NodeJS version#4501
Open
ozovalihasan wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to standardize the Node.js version used in this repo to reduce build incompatibilities across local development, Docker builds, and CI.
Changes:
- Adds a Node.js version pin via
package.jsonenginesand a new.node-versionfile. - Reverts the previous
sasspin by changing it to a semver range, which updatesyarn.lockto newer Sass/transitive dependencies.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
package.json |
Adds engines.node and loosens the sass dependency constraint. |
.node-version |
Introduces a single source-of-truth Node version for tooling that reads this file. |
yarn.lock |
Updates locked dependency versions due to the sass range change (including Sass and its transitive deps). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e" | ||
| "packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e", | ||
| "engines": { | ||
| "node": "24.14.1" |
Collaborator
Author
There was a problem hiding this comment.
If there is an incompatibility, It is expected to update NodeJS version. So, this pinned version is added on purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, it is allowed to use different NodeJS versions to build docker container and run locally.
It is causing incompatibilities like this. So,
engineskey topackage.jsonto compare versions of used and expected NodeJS.node-versionfile is added to detect node version byasdfsassversion is reverted because this issue is raised with specific versions of NodeJS(22.0.0 and 20.0.0), but this issue is not raised with v24.14.1Related Issue
--
Type of Change
Checklist
rake test)-- Not necessary
-- Not necessary