Skip to content

Add NodeJS version#4501

Open
ozovalihasan wants to merge 2 commits into
masterfrom
update-node-version
Open

Add NodeJS version#4501
ozovalihasan wants to merge 2 commits into
masterfrom
update-node-version

Conversation

@ozovalihasan

@ozovalihasan ozovalihasan commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Description

Currently, it is allowed to use different NodeJS versions to build docker container and run locally.

image

It is causing incompatibilities like this. So,

  • engines key to package.json to compare versions of used and expected NodeJS
  • .node-version file is added to detect node version by asdf
  • Changes of sass version is reverted because this issue is raised with specific versions of NodeJS(22.0.0 and 20.0.0), but this issue is not raised with v24.14.1

Related Issue

--

Type of Change

  • 📦 Dependency & security updates
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix
  • 📚 Examples / documentation / tutorials

Checklist

  • I've written tests (if applicable) for all new methods and classes that I created. (rake test)
    -- Not necessary
  • I've added documentation as necessary so users can easily use and understand this feature/fix.
    -- Not necessary

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to standardize the Node.js version used in this repo to reduce build incompatibilities across local development, Docker builds, and CI.

Changes:

  • Adds a Node.js version pin via package.json engines and a new .node-version file.
  • Reverts the previous sass pin by changing it to a semver range, which updates yarn.lock to newer Sass/transitive dependencies.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
package.json Adds engines.node and loosens the sass dependency constraint.
.node-version Introduces a single source-of-truth Node version for tooling that reads this file.
yarn.lock Updates locked dependency versions due to the sass range change (including Sass and its transitive deps).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
"packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e"
"packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e",
"engines": {
"node": "24.14.1"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is an incompatibility, It is expected to update NodeJS version. So, this pinned version is added on purpose.

Comment thread package.json
@pglombardo pglombardo added the docker Pull requests that update Docker code label Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docker Pull requests that update Docker code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants