dm: fix data race in cached WhereHandle#12693
Open
OliverS929 wants to merge 1 commit into
Open
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
ti-chi-bot
Bot
added
release-note
OliverS929
force-pushed
the
fix-issue-12688-wherehandle-race
branch
from
7c20f25 to
9613602
Compare
ti-chi-bot
Bot
added
size/L
OliverS929
force-pushed
the
fix-issue-12688-wherehandle-race
branch
from
9613602 to
8379d94
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
size/M
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
OliverS929
force-pushed
the
fix-issue-12688-wherehandle-race
branch
from
8379d94 to
5fb01b0
Compare
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #12688
DM may reuse the same cached
WhereHandleacross DML workers, whilegetWhereIdxByData()may reorderUniqueIdxsin place.What is changed and how it works?
Protect
UniqueIdxsreordering and readers with a mutex while preserving the existing behavior.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note