Conversation
`precompileShaders` is a function to time slice the shader compilations to prevent the main thread from being blocked This function only supports WebGLRenderer at the moment
improve time slicing efficiency by using `renderer.compileAsync`
scene.add should be at after the precompileShaders
Contributor
Author
|
We are reluctant to merge this since this is a feature that each application requires their specific interfaces / implementations by demand |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
VRMUtils.precompileShaders.precompileShadersis a function to time slice the shader compilations to prevent the main thread from being blocked.This function only supports WebGLRenderer at the moment.
Points need review
VRMUtilslately,,,WebGLRenderer.compile(),WebGLRenderer.compileAsync(),WebGLRenderer.initTexture()precompileShaders,compileShaders,compileShadersAsync,precompile,compile,timeslicedCompile,timeslicedCompileAsync,prepareMaterials,prepareMaterialsAsync, ...Promiseother than loader plugins.