Manage-schema-extensions-list-based-storage#5785
Manage-schema-extensions-list-based-storage#5785joaojmendes wants to merge 2 commits intopnp:mainfrom
Conversation
Sample PR validation for #5785
|
| Validation | Status |
|---|---|
| Pull request affects only one folder | |
| Sample folder name follows naming convention | ✅ Succeeded |
| Sample requires a .nvmrc file | |
| Sample requires a README.md | |
| Sample requires a screenshot .png in assets folder | |
| No .sppkg file | ✅ Succeeded |
| No node_modules folder | ✅ Succeeded |
| No lib folder | ✅ Succeeded |
| No upgrade reports | ✅ Succeeded |
@joaojmendes please address the above issues and push new changes to this branch.
For more information, see the contribution guidance.
|
@joaojmendes this is going to be a fantastic sample, but do you think you can look at the merge conflicts? Also, it seems that the PR affects a few folders |
|
@joaojmendes following up on this. If you don't mind updating your PR to only affect one folder and to solve conflicts, I am looking forward to merging this fantastic contribution. |
|
Oh @hugoabernier sorry I am only saw your comments now :( , let me fix! |
- Add useSchemaExtensionStorage hook for managing hidden SharePoint list - Auto-provision SchemaExtensionsConfig list on App Catalog site - Update useSchemaExtension to use list storage instead of tenant properties - Fix permission check logic in ManageSchemaExtensions component - Update localization strings for en-us and pt-pt This change allows the web part to work with Site Collection Admin permissions instead of requiring SharePoint Admin role.
joaojmendes
force-pushed
the
manage-schema-extensions-list-based-storage
branch
from
37aea80 to
59849c4
Compare
Sample PR validation for #5785
|
| Validation | Status |
|---|---|
| Pull request affects only one folder | ✅ Succeeded |
| Sample folder name follows naming convention | ✅ Succeeded |
| Sample requires a .nvmrc file | |
| Sample requires a README.md | |
| Sample requires a screenshot .png in assets folder | |
| No .sppkg file | ✅ Succeeded |
| No node_modules folder | ✅ Succeeded |
| No lib folder | ✅ Succeeded |
| No upgrade reports | ✅ Succeeded |
@joaojmendes please address the above issues and push new changes to this branch.
For more information, see the contribution guidance.
|
@hugoabernier done! |
|
Thanks @joaojmendes . I still seem to get the following errors: Error - [tsc] src/components/ManageSchemaExtensions/ManageSchemaExtensions.tsx(40,7): error TS6133: 'MANAGED_WEB' is declared but its value is never read. |
2 participants
What's in this Pull Request?
Change the way the Application save the schemaIdscreated, now use a hidden list create on appcatalog. The list is created if not exists on first try to save a schemaId