Add ability to sync metadata across difficulties in editor setup#37465
Open
Hiviexd wants to merge 5 commits intoppy:masterfrom
Open
Add ability to sync metadata across difficulties in editor setup#37465Hiviexd wants to merge 5 commits intoppy:masterfrom
Hiviexd wants to merge 5 commits intoppy:masterfrom
Conversation
bdach
requested changes
Apr 22, 2026
| try | ||
| { | ||
| var beatmapWorking = beatmaps.GetWorkingBeatmap(b); | ||
| beatmaps.Save(b, beatmapWorking.GetPlayableBeatmap(b.Ruleset)); |
Collaborator
There was a problem hiding this comment.
This is likely completely dropping beatmap skin-related ini keys like combo colours and such.
Compare:
osu/osu.Game/Screens/Edit/Setup/ResourcesSection.cs
Lines 215 to 220 in 95648a3
| editor?.Save(); | ||
| } | ||
|
|
||
| private static void copySyncedMetadataTo(BeatmapMetadata source, BeatmapMetadata target) |
Collaborator
There was a problem hiding this comment.
Don't really get why this is a separate method. Not like anything else is going to ever call it. Probably inline it.
| RelativeSizeAxes = Axes.X, | ||
| Text = EditorSetupStrings.SyncMetadataWithAllDifficulties, | ||
| TooltipText = EditorSetupStrings.SyncMetadataWithAllDifficultiesTooltip, | ||
| Action = syncMetadataToAllOtherDifficulties, |
Collaborator
There was a problem hiding this comment.
This is a potentially-destructive action that will likely never support undo. I think a confirmation dialog is warranted. Or at least some hold-to-confirm facility on the button itself to prevent accidents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NVIDIA_Overlay_wQbbcYQ7sa.mp4
This has been a pain point in both lazer and stable, and people usually use external tools for this kind of stuff for stable.