Add skinning support to osu! cookie's heartbeat sound#37484
Open
diquoks wants to merge 3 commits intoppy:masterfrom
Open
Add skinning support to osu! cookie's heartbeat sound#37484diquoks wants to merge 3 commits intoppy:masterfrom
diquoks wants to merge 3 commits intoppy:masterfrom
Conversation
peppy
requested changes
Apr 26, 2026
diquoks
force-pushed
the
quick-fix/skinnable-cookie-heartbeat
branch
from
572fdb1 to
8814ce8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not sure about
hearbeatusage is necessary in both samples, but judging by my tests in stable and reading the wiki there, implemented there like thisi would also like to introduce full support for skinnable sounds in the main menu, if you deem it necessary
also, this skin was used for tests