Eagerly connect to latest server instance for best online experience#37506
Open
peppy wants to merge 5 commits intoppy:masterfrom
Open
Eagerly connect to latest server instance for best online experience#37506peppy wants to merge 5 commits intoppy:masterfrom
peppy wants to merge 5 commits intoppy:masterfrom
Conversation
peppy
added
the
area:online functionality
peppy
force-pushed
the
better-graceful-shutdown
branch
from
af2b659 to
258e4d0
Compare
The `Disconnect` method, while it might look correct on the surface, is actually a forceful disconnect which logs out of the API too..
peppy
force-pushed
the
better-graceful-shutdown
branch
from
258e4d0 to
2505388
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client side requirements for making the client connect as soon as possible, based on how the client is being used. This is especially important with the introduction of ranked play: previously the worst case scenario would be that you couldn't join a multiplayer room (or spectate a user) and this was automatically handled mostly*, but now, if you leave the game open for a while, you can potentially be stuck queueing in ranked play with no users remaining on your server.
Some samples of how this looks follow. Do note that the client is showing "Server is shutting down" errors. This is only going to happen in local debug environments – In production, when you reconnect to the endpoint you will always get a non-shutting-down instance.
Idle scenario:
osu.2026-04-24.at.08.01.38.mp4
Non-idle scenario:
osu.2026-04-24.at.09.02.33.mp4