Apply 0.0001f precision to some Tablet Settings#37515
Open
Mrcubix wants to merge 2 commits intoppy:masterfrom
Open
Apply 0.0001f precision to some Tablet Settings#37515Mrcubix wants to merge 2 commits intoppy:masterfrom
Mrcubix wants to merge 2 commits intoppy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have a control where a slider & input box coexist, I think it's the right time to fix #34714.
The root of the issue stems from using rounded values for Tablet Settings (due to various Bindables lacking Precision parameters).
This PR sets the precision for those Bindables to
0.0001fas well as the keyboard step.Not exactly sure I want to keep KeyboardStep at
0.0001f.Kinda out of scope, but I wonder if it would be a good idea to be able to use modifier keys to increase the increment.