Show ranked play rankings in RankingsOverlay#37531
Open
LiquidPL wants to merge 2 commits intoppy:masterfrom
Open
Show ranked play rankings in RankingsOverlay#37531LiquidPL wants to merge 2 commits intoppy:masterfrom
RankingsOverlay#37531LiquidPL wants to merge 2 commits intoppy:masterfrom
Conversation
Depends on ppy/osu-web#12940. Still unsure on the naming of some things, as you can find both `Matchmaking` and `RankedPlay`, and the whole thing still effectively covers any matchmaking pools we might ever have in the backend. Also the requests don't implement any pagination yet, since that part is still being discussed in the web-side PR, and additionally, if I understand correctly, the client isn't doing any pagination on the rankings anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on ppy/osu-web#12940.
Still unsure on the naming of some things, as you can find both
MatchmakingandRankedPlay, and the whole thing still effectivelycovers any matchmaking pools we might ever have in the backend.
Also the requests don't implement any pagination yet, since that part is
still being discussed in the web-side PR, and additionally, if I
understand correctly, the client isn't doing any pagination on the
rankings anyway.