Added "LN Ratio" display in Mania in the place of useless "key count"#37581
Open
pacowoc wants to merge 4 commits intoppy:masterfrom
Open
Added "LN Ratio" display in Mania in the place of useless "key count"#37581pacowoc wants to merge 4 commits intoppy:masterfrom
pacowoc wants to merge 4 commits intoppy:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| using var reader = new StreamReader(resourceStream); | ||
| return JsonConvert.DeserializeObject<APIBeatmap[]>(reader.ReadToEnd())!; | ||
| } | ||
| case "mania": |
| using var reader = new StreamReader(resourceStream); | ||
| return JsonConvert.DeserializeObject<APIBeatmap[]>(reader.ReadToEnd())!; | ||
| } | ||
| default: |
| { | ||
| private RankedPlayScreen screen = null!; | ||
|
|
||
| [Resolved] |
|
|
||
| [Resolved] | ||
| private RulesetStore rulesetStore { get; set; } = null!; | ||
| private RankedPlayScreen screen = null!; |
| AddStep("load screen", () => LoadScreen(screen = new RankedPlayScreen(MultiplayerClient.ClientRoom!))); | ||
| AddUntilStep("screen loaded", () => screen.IsLoaded); | ||
| } | ||
| [Test] |
|
i think this should be solved by changing the implementation of ManiaRuleset.GetBeatmapAttributesForDisplay instead? this feels very hacky. there is also no consideration for localization because the attribute labels currently use SongSelectStrings. also, the number should also be formatted as a percentage if anything. |
Author
There are absolutely zero consideration of localization in 99% of ranked UI anyways |
| }; | ||
| } | ||
|
|
||
| public override IEnumerable<RulesetBeatmapAttribute> GetBeatmapAttributesForDisplay(IBeatmapInfo beatmapInfo, IReadOnlyCollection<Mod> mods, int SliderCount) |
| yield return new RulesetBeatmapAttribute(SongSelectStrings.Accuracy, @"OD", originalDifficulty.OverallDifficulty, adjustedDifficulty.OverallDifficulty, 10); | ||
| yield return new RulesetBeatmapAttribute(SongSelectStrings.HPDrain, @"HP", originalDifficulty.DrainRate, adjustedDifficulty.DrainRate, 10); | ||
| } | ||
| /// <summary> |
| /// <summary> | ||
| /// Overload of <see cref="GetAdjustedDisplayDifficulty"/> for display on Ranked Cards | ||
| /// </summary> | ||
| public virtual IEnumerable<RulesetBeatmapAttribute> GetBeatmapAttributesForDisplay(IBeatmapInfo beatmapInfo, IReadOnlyCollection<Mod> mods, int SliderCount) |
| }, | ||
| ..ruleset.GetBeatmapAttributesForDisplay(beatmap, []) | ||
| .Select(attribute => new AttributeRow(attribute)) | ||
| ..(beatmap.RulesetID==3 ? ruleset.GetBeatmapAttributesForDisplay(beatmap, [],beatmap.SliderCount) : ruleset.GetBeatmapAttributesForDisplay(beatmap, [])) |
| }, | ||
| ..ruleset.GetBeatmapAttributesForDisplay(beatmap, []) | ||
| .Select(attribute => new AttributeRow(attribute)) | ||
| ..(beatmap.RulesetID==3 ? ruleset.GetBeatmapAttributesForDisplay(beatmap, [],beatmap.SliderCount) : ruleset.GetBeatmapAttributesForDisplay(beatmap, [])) |
| }, | ||
| ..ruleset.GetBeatmapAttributesForDisplay(beatmap, []) | ||
| .Select(attribute => new AttributeRow(attribute)) | ||
| ..(beatmap.RulesetID==3 ? ruleset.GetBeatmapAttributesForDisplay(beatmap, [],beatmap.SliderCount) : ruleset.GetBeatmapAttributesForDisplay(beatmap, [])) |
| ..ruleset.GetBeatmapAttributesForDisplay(beatmap, []) | ||
| .Select(attribute => new AttributeRow(attribute)) | ||
| ..(beatmap.RulesetID==3 ? ruleset.GetBeatmapAttributesForDisplay(beatmap, [],beatmap.SliderCount) : ruleset.GetBeatmapAttributesForDisplay(beatmap, [])) | ||
| .Select(attribute => |
| ..(beatmap.RulesetID==3 ? ruleset.GetBeatmapAttributesForDisplay(beatmap, [],beatmap.SliderCount) : ruleset.GetBeatmapAttributesForDisplay(beatmap, [])) | ||
| .Select(attribute => | ||
| { | ||
| return new AttributeRow(attribute); |
| { | ||
| private float normalizedValue => float.Clamp(attribute.AdjustedValue / attribute.MaxValue, 0, 1); | ||
|
|
||
| private string getAdjustedValuestring() |
| { | ||
| case "LN Ratio": | ||
| return attribute.AdjustedValue.ToString("P1"); | ||
| default: |
Author
|
Also the Tests here are bugging so much that it is insane, the pickscreen test stop midway on first run but runs normally on second run lmao, idk why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Key Count" metric in mania is very useless since you are already expected to play maps with a specific Key Count when you are queueing.
This PR inserts the proportion of LNs (Long Notes) in the place of that metric since it is one of the ways players can gudge their skillsets (This idea comes from reddit)
Also improved the test suite for other skillsets by making the architecture more minor ruleset friendly