Move unknown_field_set.h to protobuf_lite to allow direct usage from the parser without a virtual dispatch.#28084
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Move unknown_field_set.h to protobuf_lite to allow direct usage from the parser without a virtual dispatch.#28084copybara-service[bot] wants to merge 1 commit into
unknown_field_set.h to protobuf_lite to allow direct usage from the parser without a virtual dispatch.#28084copybara-service[bot] wants to merge 1 commit into
Conversation
…rom the parser without a virtual dispatch. Move the minimal set of function from `unknown_field_set.cc` to `unknown_field_set_lite.cc` Change the parser fallback function to separate the extensions case from the unknown field case. This makes both cases faster. PiperOrigin-RevId: 933183605
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
unknown_field_set.htoprotobuf_liteto allow direct usage from the parser without a virtual dispatch.Move the minimal set of function from
unknown_field_set.cctounknown_field_set_lite.ccChange the parser fallback function to separate the extensions case from the unknown field case. This makes both cases faster.