fix: make pip install -e . work for ComfyUI portable users#155
Open
fix: make pip install -e . work for ComfyUI portable users#155
Conversation
Add explicit [tool.setuptools.packages.find] with include config to prevent setuptools from discovering asset directories (js/, images/) as packages. Also add missing aiohttp dependency imported in __init__.py.
aiohttp is imported in __init__.py but was missing from requirements.txt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pip install -e .failing with "Multiple top-level packages discovered in a flat-layout" error for ComfyUI portable usersaiohttpdependency that's imported in__init__.pybut only listed inrequirements.txtChanges
pyproject.toml: Added explicit[tool.setuptools.packages.find]section withinclude = ["comfyui_to_python*"]to prevent setuptools from discovering asset directories (js/,images/) as packagespyproject.toml: Addedaiohttpto project dependencies (was only inrequirements.txt)tests/test_project_contracts.py: Added 2 contract tests to verify both fixes and prevent regressionValidation
pip install -e .succeeds in a clean venv with no errors