Skip to content

Add C++ unit tests for cadence::quantized_conv1d_ncl.out and quantized_conv1d_nlc.out (#19161)#19161

Open
hsharma35 wants to merge 1 commit intopytorch:mainfrom
hsharma35:export-D97886683
Open

Add C++ unit tests for cadence::quantized_conv1d_ncl.out and quantized_conv1d_nlc.out (#19161)#19161
hsharma35 wants to merge 1 commit intopytorch:mainfrom
hsharma35:export-D97886683

Conversation

@hsharma35
Copy link
Copy Markdown
Contributor

@hsharma35 hsharma35 commented Apr 27, 2026

Summary:

Adds C++ unit tests for cadence::quantized_conv1d_ncl.out and cadence::quantized_conv1d_nlc.out in test_op_quantized_conv1d_ncl.cpp. Also modifies op_quantized_conv1d_ncl.cpp and op_quantized_conv1d_nlc.cpp in the HiFi backend to fix correctness issues surfaced by the new tests.

Reviewed By: mcremon-meta, zonglinpeng

Differential Revision: D97886683

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 27, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19161

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 3 Cancelled Jobs, 2 Pending, 2 Unrelated Failures

As of commit 612d296 with merge base 9207001 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 27, 2026
@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@hsharma35 hsharma35 force-pushed the export-D97886683 branch 3 times, most recently from b0b86c9 to b45a85a Compare April 27, 2026 20:29
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Apr 27, 2026

@hsharma35 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97886683.

hsharma35 added a commit to hsharma35/executorch that referenced this pull request Apr 27, 2026
…d_conv1d_nlc.out (pytorch#19161)

Summary:
Pull Request resolved: pytorch#19161

Adds C++ unit tests for cadence::quantized_conv1d_ncl.out and cadence::quantized_conv1d_nlc.out in test_op_quantized_conv1d_ncl.cpp. Also modifies op_quantized_conv1d_ncl.cpp and op_quantized_conv1d_nlc.cpp in the HiFi backend to fix correctness issues surfaced by the new tests.

Reviewed By: mcremon-meta

Differential Revision: D97886683
@meta-codesync meta-codesync Bot changed the title Add C++ unit tests for cadence::quantized_conv1d_ncl.out and quantized_conv1d_nlc.out Add C++ unit tests for cadence::quantized_conv1d_ncl.out and quantized_conv1d_nlc.out (#19161) Apr 27, 2026
hsharma35 added a commit to hsharma35/executorch that referenced this pull request Apr 27, 2026
…d_conv1d_nlc.out (pytorch#19161)

Summary:
Pull Request resolved: pytorch#19161

Adds C++ unit tests for cadence::quantized_conv1d_ncl.out and cadence::quantized_conv1d_nlc.out in test_op_quantized_conv1d_ncl.cpp. Also modifies op_quantized_conv1d_ncl.cpp and op_quantized_conv1d_nlc.cpp in the HiFi backend to fix correctness issues surfaced by the new tests.

Reviewed By: mcremon-meta

Differential Revision: D97886683
@hsharma35 hsharma35 changed the title Add C++ unit tests for cadence::quantized_conv1d_ncl.out and quantized_conv1d_nlc.out (#19161) Add C++ fixes for cadence::quantized_conv1d_ncl.out and quantized_conv1d_nlc.out (#19161) Apr 27, 2026
…d_conv1d_nlc.out (pytorch#19161)

Summary:

Adds C++ unit tests for cadence::quantized_conv1d_ncl.out and cadence::quantized_conv1d_nlc.out in test_op_quantized_conv1d_ncl.cpp. Also modifies op_quantized_conv1d_ncl.cpp and op_quantized_conv1d_nlc.cpp in the HiFi backend to fix correctness issues surfaced by the new tests.

Reviewed By: mcremon-meta, zonglinpeng

Differential Revision: D97886683
@meta-codesync meta-codesync Bot changed the title Add C++ fixes for cadence::quantized_conv1d_ncl.out and quantized_conv1d_nlc.out (#19161) Add C++ unit tests for cadence::quantized_conv1d_ncl.out and quantized_conv1d_nlc.out (#19161) Apr 28, 2026
hsharma35 added a commit to hsharma35/executorch that referenced this pull request Apr 28, 2026
…d_conv1d_nlc.out (pytorch#19161)

Summary:

Adds C++ unit tests for cadence::quantized_conv1d_ncl.out and cadence::quantized_conv1d_nlc.out in test_op_quantized_conv1d_ncl.cpp. Also modifies op_quantized_conv1d_ncl.cpp and op_quantized_conv1d_nlc.cpp in the HiFi backend to fix correctness issues surfaced by the new tests.

Reviewed By: mcremon-meta, zonglinpeng

Differential Revision: D97886683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants