Enable ROCm CI support.

[akashveramd]

In this PR-

• Added support for creating ROCm docker image for torchtian and running torchtitan tests on ROCm.
• Added ROCm CI support for integration_test unit test.

[facebook-github-bot]

Hi @akashveramd!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[pytorch-bot]

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

[jithunnair-amd]

This logic makes sense to me, but if we really want to use the test setting in integration_tests_h100.py, we should move this logic to that file (and of course rename it to be more agnostic).

[akashveramd]

@jithunnair-amd : All tests in integration_tests_h100.py passes for rocm. Hence, we don't TEST_WITH_ROCM in integration_tests_h100.py. However, we need to talk about renaming integration_tests_h100.py filename as we also run it on rocm runners.
cc: @tianyu-l @fegin

[jithunnair-amd]

@huydhn Need your help in creating a new docker repo for torchtitan ROCm docker image: https://github.com/pytorch/torchtitan/actions/runs/16042425274/job/45266420732?pr=1260#step:7:1436

name unknown: The repository with name 'torchtitan/torchtitan-rocm-ubuntu-22.04-clang12' does not exist in the registry with id '308535385114'

[akashveramd]

@fegin @tianyu-l @huydhn: The aws setup fails in integration_test_8gpu.yaml workflow file. Can we get help for granting this role arn:aws:iam::308535385114:role/gha_workflow_s3_and_ecr_read_only for torchtitan?

[huydhn]

From what I see torchtitan should already have permission to that role:

name = "gha_workflow_s3_and_ecr_read_only"

max_session_duration = 18000
description = "Allows github actions running on PyTorch to have read only access to ECR and s3://gha-artifacts/ bucket"
assume_role_policy = jsonencode({
  Version = "2012-10-17"
  Statement = [
    {
      Effect = "Allow"
      Principal = {
        Federated = "arn:aws:iam::308535385114:oidc-provider/token.actions.githubusercontent.com"
      }
      Action = "sts:AssumeRoleWithWebIdentity"
      Condition = {
        StringEquals = {
          "token.actions.githubusercontent.com:aud" = "sts.amazonaws.com"
        }
        "ForAnyValue:StringLike" = {
          "token.actions.githubusercontent.com:sub" = [
            "repo:pytorch/ao:*",
            "repo:pytorch/pytorch:*",
            "repo:pytorch/test-infra:*",
            "repo:pytorch/torchtitan:*", <-- This one
          ]
        }
      }
    }
  ]
})

I suspect that the error happens because your PR is a forked PR from https://github.com/akashveramd/torchtitan, not https://github.com/pytorch/torchtitan. So, I'm trying to test that out in #1782. If this is the case, we need to implement ciflow/rocm in torchtitan to address this issue, same as the rocm workflow in PyTorch https://github.com/pytorch/pytorch/blob/main/.github/workflows/rocm.yml#L9

[huydhn]

It is confirmed https://github.com/pytorch/torchtitan/actions/runs/18179897492/job/51753630586?pr=1782 that authentication works on a non-forked PR. This makes sense because the grant is only to pytorch/torchtitan, so we will need ciflow/rocm and a separate workflow for rocm here unfortunately

[akashveramd]

Closing in favor of PR: #1786