ci: pin Windows release runner to windows-2022

[dinex-dev]

Why

The Release Desktop App workflow has been failing during Install desktop app dependencies (e.g. run 27961047810). The registry-js native module fails to compile because node-gyp can't find a usable Visual Studio:

gyp ERR! find VS unknown version "undefined" found at "C:\Program Files\Microsoft Visual Studio\18\Enterprise"
gyp ERR! find VS could not find a version of Visual Studio 2017 or newer to use

windows-latest now provisions the VS 2026 (v18) toolchain, which the bundled node-gyp@9.3.1 (from Node 20.9.0) cannot detect — it parses the version as undefined and bails. Not a code change on our side; the runner image moved.

What

Pin the Windows runner to windows-2022 (VS 2022 / v17), which node-gyp understands. Replaced windows-latest across:

• the build_type dropdown option and its default
• the two Windows-only KMS signing step gates (Auth to Google Cloud, Install + configure KMS CNG provider)
• the USE_KMS_SIGNING env expression

All changed together so runs-on and the == 'windows-2022' gates stay consistent — otherwise the codesigning steps would silently stop matching and produce an unsigned build.

Note

windows-2022 is being deprecated by GitHub over time, so this is a stable pin, not a permanent fix. The durable fix is upgrading node-gyp/Node to recognize VS 2026 — worth a follow-up.

Testing

Re-run the release workflow and select windows-2022 (now the default).

🤖 Generated with Claude Code

Summary by CodeRabbit

• Chores
  • Updated the Windows desktop application release workflow to standardize builds on Windows 2022. The manual build option now defaults to Windows 2022, and Windows-only Google Cloud KMS signing steps are now applied only to Windows 2022 builds.

[coderabbitai]

Warning

Review limit reached

@dinex-dev, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 22 minutes and 38 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1631676b-c867-4517-a08a-c67b4f54c236

📥 Commits

Reviewing files that changed from the base of the PR and between a091811 and f93de84.

📒 Files selected for processing (1)

• .github/workflows/release_desktop_app.yml

Walkthrough

The release desktop app GitHub Actions workflow replaces all occurrences of windows-latest with the pinned runner label windows-2022. The workflow_dispatch build_type input options are updated so windows-2022 replaces windows-latest and becomes the new default. A comment referencing the Windows runner for distutils/node-gyp support is updated accordingly. The conditional guards on the Google Cloud KMS authentication step and the KMS CNG provider install/configure step are changed from build_type == 'windows-latest' to build_type == 'windows-2022'. The USE_KMS_SIGNING environment variable expression is updated to match the same condition. The workflow branch/ref gate is temporarily disabled by commenting out the prior condition with TEMP/RESTORE markers.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• requestly/http-interceptor-desktop-app#339: Introduced the Google Cloud KMS Windows signing setup steps and USE_KMS_SIGNING gating that this PR re-targets from windows-latest to windows-2022.
• requestly/http-interceptor-desktop-app#342: Also modifies .github/workflows/release_desktop_app.yml to adjust platform-specific build and signing configurations gated by build_type.

Suggested reviewers

• nsrCodes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'ci: pin Windows release runner to windows-2022' directly and accurately summarizes the main change: pinning the Windows release runner to windows-2022 instead of windows-latest.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ci/pin-windows-2022-runner

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}