Feature/add isdescendant and isancestor method#75
Open
aoifukuoka wants to merge 2 commits intorobbiehanson:masterfrom
Open
Feature/add isdescendant and isancestor method#75aoifukuoka wants to merge 2 commits intorobbiehanson:masterfrom
aoifukuoka wants to merge 2 commits intorobbiehanson:masterfrom
Conversation
Collaborator
|
DDXML is supposed to mirror the upstream NSXML API, allowing the end user to swap out KissXML for NSXML on macOS. Perhaps this can be moved to a generic category method on NSXMLNode that works on both? NSXMLNode+DDXML.h, and then prefix the methods with Also, please add a test here to ensure that your category : https://github.com/robbiehanson/KissXML/blob/master/Tests/Shared/KissXMLTests.m |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. This adds two method.
I wrote this method along with Swift 3.
This method returns if given node is descendant of self.
This method returns if given node is ancestor of self.
please review my PR.
Thank you.