Address improper configuration when transitioning between child and parent states#88
Open
yassiezar wants to merge 12 commits intorobosoft-ai:feature/stateMachineActionRacefrom
Open
Conversation
yassiezar
changed the base branch from
feature/stateMachineActionRace
to
noetic-devel
yassiezar
changed the base branch from
noetic-devel
to
feature/stateMachineActionRace
Collaborator
|
We accept your proposal. Before we merge the changes into our codebase, I would like to conduct a final validation by testing some of our existing examples. Thank you for your contribution! |
Contributor
Author
|
No problem, let me know if I can help with integration or testing |
SMACC1 RTA Instructions added to README.md
Update README.md
…ocks, added guard that prevents notifyOnStateEntryEnd from being called prematurely when transitioning between a parent and child state
yassiezar
force-pushed
the
feature/stateMachineActionRace
branch
from
38c5eec to
d63bfa3
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in response to #60 and builds on #87. The main change is adding a guard to prevent the
notifyOnStateEntryEnd()method from being called when there's still an inner state to be configured. In addition, I've replaced the mutex locks with an atomic - the idea is that it guarantees mutually-exclusive access to the state variable without having to manually specify a locked region.I've tested this on our system around 20 times and it consistently starts up as expected, as opposed to before where startup was much more unpredictable. However, more testing on different state configurations will be necessary to prevent regression.
┆Issue is synchronized with this Jira Task by Unito