fix(shell-ui): only show Aparavi AQL Settings in sidebar when the AQL app is installed#1310
Conversation
… app is installed Refs rocketride-ai/rocketride-saas#240 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesAparavi-gated Settings menu item
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Internal: Discord sync markerAuto-managed by the Discord notification workflow. Stores the linked Discord message ID. Do not edit or delete. |
…ings always visible (#1317) * fix(shell-ui): gate AQL Settings on isOnDesktop, not the full app catalog PR #1310 gated the sidebar Settings item on `appManifest.some(a => a.id === 'rocketride.aparavi')`, but appManifest is the full app catalog (always contains aparavi), so the check was always true and the item never hid. Use isOnDesktop('rocketride.aparavi') from useSubscriptions — the per-user signal the app switcher in the same component already uses. Refs rocketride-ai/rocketride-saas#240 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(shell-ui): show all-app settings only for installed apps; keep Settings always visible The Settings overlay (SettingsPage) is a global workspace view — shell "General" settings plus the settings of every app in appManifest. appManifest is the full catalog, so an uninstalled app's settings (e.g. Aparavi AQL) showed for everyone: the real cause of the #240 report. - SettingsPage: skip apps that aren't on the user's desktop (app.onDesktop) when building per-app sections. Shell "General" settings are unaffected. - Sidebar: revert the earlier gating that hid the whole Settings item when Aparavi wasn't installed — Settings is global and is now always shown. Fixes the regression where the Settings tab disappeared entirely. Refs rocketride-ai/rocketride-saas#240 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(shell-ui): settings nav shows one section per page instead of stacking all The settings sidebar nav didn't paginate: with no selection (and when "General" was selected) every section rendered stacked on one page, and selecting an app showed General + that app together. Re-clicking deselected back to "show all". Now each nav button is its own page: default to the first section (General), render only the selected section, and treat search as a cross-section override. Refs rocketride-ai/rocketride-saas#240 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The shared app sidebar footer rendered a "Settings" entry unconditionally. That settings overlay is Aparavi-AQL-specific, so it appeared in every app even when the Aparavi AQL app was not installed.
This gates the footer "Settings" menu item on the Aparavi AQL app (
rocketride.aparavi) being present inappManifest(fromuseWorkspace()). When the app is not installed the item is simply omitted; all other footer items are unchanged, and the item keeps its original position (after Variables, before Theme) when it is shown.Refs rocketride-ai/rocketride-saas#240
🤖 Generated with Claude Code
Summary by CodeRabbit