Skip to content

Update settings-production.yml#113

Open
maelle wants to merge 1 commit intoropenscifrom
maelle-patch-2
Open

Update settings-production.yml#113
maelle wants to merge 1 commit intoropenscifrom
maelle-patch-2

Conversation

@maelle
Copy link
Copy Markdown
Collaborator

@maelle maelle commented Jun 23, 2025

@mpadge do you think it is what's needed to prevent ropensci/software-review#698 (comment) (when the response had been submitted)?

@mpadge
Copy link
Copy Markdown
Collaborator

mpadge commented Jun 23, 2025

Um, no, alas. We had discussed this earlier somewhere. The problem with that transition is that it should only happen once all responses have been logged, and that requires conditional responses (#24) which aren't (currently) possible. In your proposed form, the whole process would be stopped as soon as first response was logged, which is not what we want. Right?

@maelle
Copy link
Copy Markdown
Collaborator Author

maelle commented Jun 23, 2025

@mpadge to clarify this is about the reviewer's response to the reviews, not the reviewers' responses to the author's response. 🤪

@mpadge
Copy link
Copy Markdown
Collaborator

mpadge commented Jun 23, 2025

@mpadge to clarify this is about the reviewer's response to the reviews, not the reviewers' responses to the author's response. 🤪

Yeah, I did get that. I was trying but failed to find a table I made somewhere of all of the label transitions and mechanisms needed for each. That had details of why 4 -> 5 could not be automated. Do you remember that? Do you have any idea where it was?

@maelle
Copy link
Copy Markdown
Collaborator Author

maelle commented Jul 1, 2025

Ouch, no, sorry.

xuanxu added a commit that referenced this pull request Mar 24, 2026
Adding aliases for assign and unassign
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants