Skip to content

link in reviewer guide to stats template for stats reviews#1012

Open
mpadge wants to merge 10 commits into
mainfrom
reviewer-stats
Open

link in reviewer guide to stats template for stats reviews#1012
mpadge wants to merge 10 commits into
mainfrom
reviewer-stats

Conversation

@mpadge

@mpadge mpadge commented May 25, 2026

Copy link
Copy Markdown
Member

Checklist for dev guide maintainers, do not delete 😸

  • Review of the content in the initial language.
  • News item.
  • Translation of the content in other languages.
  • Review of the translations.

@maelle maelle requested review from a team as code owners May 29, 2026 08:38
@maelle maelle requested review from fblpalmeira and removed request for a team May 29, 2026 08:38

@fblpalmeira fblpalmeira left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done @maelle

Comment thread softwarereview_reviewer.pt.Rmd Outdated
Comment thread softwarereview_reviewer.pt.Rmd Outdated
Comment thread softwarereview_reviewer.pt.Rmd Outdated

Para revisar um pacote, comece copiando o nosso [modelo de revisão](#reviewtemplate) e use ele como uma lista de verificações que precisam ser feitas. Além de marcar os critérios mínimos, pedimos que você forneça comentários gerais abordando o seguinte:
Para revisar um pacote, comece copiando nosso [modelo de revisão](#reviewtemplate) ou o modelo [modelo de revisão de estatísticas](https://stats-devguide.ropensci.org/pkgreview.html#pkgrev-template) para software estatístico.
Esses modelos devem ser usados como listas de verificação de alto nível.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do we mean by "high-level checklists"?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpadge can you please clarify?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - I've updated the English version from this:

These templates should be used as high-level checklists.

to this:

These templates should be used as high-level checklists to guide initial review structure.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please update the translations @mpadge using either https://docs.ropensci.org/babeldown/reference/deepl_translate_clipboard.html or DeepL's web interface? Thank you!

@maelle

maelle commented Jun 1, 2026

Copy link
Copy Markdown
Member

Thanks a ton @fblpalmeira @beatrizmilz!

Co-authored-by: Beatriz Milz <42153618+beatrizmilz@users.noreply.github.com>
Comment thread softwarereview_reviewer.Rmd Outdated
Comment thread softwarereview_reviewer.pt.Rmd Outdated
Comment thread softwarereview_reviewer.es.Rmd Outdated
@maelle maelle requested a review from fblpalmeira June 1, 2026 09:15
beatrizmilz and others added 2 commits June 1, 2026 09:22
Co-authored-by: mark padgham <mark.padgham@email.com>
Co-authored-by: mark padgham <mark.padgham@email.com>
Comment thread softwarereview_reviewer.es.Rmd Outdated
@yabellini

Copy link
Copy Markdown
Member

Hola! Done 😄

@maelle

maelle commented Jun 12, 2026

Copy link
Copy Markdown
Member

@mpadge @beatrizmilz why is the diff of this commit so huge? 4661028 (this PR)

@mpadge

mpadge commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

@mpadge @beatrizmilz why is the diff of this commit so huge? 4661028 (this PR)

Yes indeed, and I'm going to have to pass that one on to @beatrizmilz

@maelle

maelle commented Jun 12, 2026

Copy link
Copy Markdown
Member

And if there's no easy answer I can fix in about 10 days so no worries!

@beatrizmilz

Copy link
Copy Markdown
Contributor

@mpadge @beatrizmilz why is the diff of this commit so huge? 4661028 (this PR)

Yes indeed, and I'm going to have to pass that one on to @beatrizmilz

@maelle @mpadge
I'm not sure... I'm looking on what @fblpalmeira and I reviewed, and seems like we did not change much...
https://github.com/ropensci/dev_guide/pull/1012/files/22d84fcc461411ab2be3135bcfda4d1950f983dd
I'll try to explore

@beatrizmilz

Copy link
Copy Markdown
Contributor

I asked Claude Code to investigate this (I hope this is not a problem), and here's what it found:

the diff of commit 4661028 is huge because that commit (applied through the GitHub web "apply suggestion" editor) converted the file's line endings from LF to CRLF. The text content itself is essentially unchanged — every line shows up as modified simply because its line terminator changed, which is why all 232 lines appear in the diff.

I checked and it makes sense...
The fix 8611a69 is to normalize the file back to LF.
Now the diff for this file in the PR is only showing the changes that we actually made in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants