Conversation
Pull Request validationFailed🔴 Review - Missing review from a member (1 required) Success🟢 CI - All checks have passed |
|
The built images have this sizes As you can see postgresql-18 image has size 423 MB based on s2i-core image, whereas postgresql-18-minimal based on ubi10-minimal image has size 368MB. |
|
Here is a reference from Dockerhub https://github.com/docker-library/postgres/blob/master/Dockerfile-debian.template The question is if debian provides upgrade as well. FYI @fila43 |
|
As this is a minimal image, then postgresql18-upgrade does not make sence, though. |
18-minimal version is added. Base images are ubi10-minimal and centos-stream-10 till base images for C11S and RHEL11 are not available Added also files `cgroup-limits` and `fix-permission` that are missing from s2i-core base image Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
is not based on s2i-core Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Also do not test upgrades and migrations on 18-minimal image Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Building of PostgreSQL 18-minimal image is based on centos-stream-10 image. Building of PostgreSQL 18-minimal image is based on ubi10-minimal image. No s2i-core image is used for building 18-minimal image. Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
This can be done by other tooling or by customer image Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
|
As the minimal package should be really minimal I have more improvements. In case we remove package In case we remove |
|
From my perspective it doesn't make sense to remove upgrade functionality from the image. Because it was one form the most required feature to fix. Even our CUs contributed on it. It would also change the behavior and feature set of the image. So I disagree with functionality removal. But I understand the effort to reduce the size. So I adjusted RPM and prepare specific server subpackage For me it seems to be a good trade of. Feel free to experiment with https://src.fedoraproject.org/rpms/postgresql18/pull-request/14 If it makes sense we can get started with reviews of RPM changes and prepare the container build. |
This pull request adds PostgreSQL 18-minimal image.
No s2i-core image is used.
common.shscriptThis pull request is blocked by #640 , sclorg/container-common-scripts#424, and sclorg/container-common-scripts#423
The fixing of tests were not covered by this pull request yet.