enable :has() selector#363
Open
yezhizhen wants to merge 9 commits into
Open
Conversation
Any ancestors of this commit are from upstream mozilla-central, with some filtering and renaming. Our patches and sync tooling start here. The sync tooling has all been squashed into this commit, based on: https://github.com/servo/stylo/commits/64731e10dc8ef87ef52aa2fb9f988c3b2530f3a7
This is a rebase of 40aa59d Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Signed-off-by: Oriol Brufau <obrufau@igalia.com>
- Bump stylo_* to 0.17.0 - Bump selectors to 0.38.0 - Bump to_shmem to 0.4.0 Signed-off-by: Oriol Brufau <obrufau@igalia.com>
…operties (#360) For standard longhands, `computed_value_to_string()` calls `computed_or_resolved_value()`, which uses `to_resolved_value()`. But for custom properties, `computed_value_to_string()` was returning the unresolved computed value. Now it will use `to_resolved_value()` too. See https://phabricator.services.mozilla.com/D287814 for reference. Servo PR: servo/servo#44856 Signed-off-by: Oriol Brufau <obrufau@igalia.com>
Collaborator
|
When @mrobinson tried this, invalidation was not working |
Collaborator
|
Yeah, |
Member
Author
Thanks. Do we have a rough idea how hard is it to support this, and where we can start from in Servo side? |
Collaborator
It's probably one of the hardest CSS feature to support! But it's definitely doable. The main trouble is that none of the requirements are documented, so it'd be a case of cribbing from the Gecko codebase and asking for help from Gecko developers (#layout in Mozilla matrix). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a scenario that is bugged by this.
Servo PR: servo/servo#44902