Enable basic SVG-related CSS properties for Servo#383
Conversation
8fb5e33 to
0145c94
Compare
xiaochengh
left a comment
There was a problem hiding this comment.
Thanks for working on this!
We discussed offline and found this all-in-one PR hard to review. We will change the plan:
- First, enable only a small set of properties for basic shapes in Stylo
- And then, implement the basic shapes and these properties in Servo
- Iterate the above process, and progressively enable more properties in Stylo and implement them in Servo
This way we can make sure that we don't introduce any unintended changes.
xiaochengh
left a comment
There was a problem hiding this comment.
Looks good in its current shape now. Let's move focus to the Servo PR.
19a8850 to
e664b45
Compare
e0eecd7 to
b847200
Compare
|
Why have the "geometric attributes" (x, y, cx, cy, rx, ry) been reverted? I think those will be needed for even a minimal implementation of SVG. |
I reverted them just to keep this PR strictly focused on fill and stroke so we can get them tested with WPT in Servo. Don't worry, geometric attributes are coming in the very next PR! That will go hand-in-hand with the Servo PR implementing the DOM elements for shapes (rect, circle, ellipse) that actually use them. |
b847200 to
a05d66d
Compare
a05d66d to
b058334
Compare
b058334 to
fdea424
Compare
- Remove engine = gecko gating and servo_pref gating from SVG properties and shorthands. - Update size_of_test. Signed-off-by: Mohamed Mostafa mu-mostafa98@gmail.com
…and keep SVG only Signed-off-by: Mohamed Mostafa mu-mostafa98@gmail.com
…geometry Signed-off-by: Mohamed Mostafa mu-mostafa98@gmail.com
76bf704 to
55cfd2f
Compare
Signed-off-by: Mohamed Mostafa mu-mostafa98@gmail.com
Removes
engine = "gecko"from 11 SVG-specific CSS properties to be enabled for servo:fill,fill-opacity,fill-rulestroke,stroke-width,stroke-linecap,stroke-linejoin,stroke-dasharray,stroke-dashoffset,stroke-miterlimit,stroke-opacityAlso updates the
ComputedValuessize test (224 → 232) for the new fields.Servo PR