fix(syntax): avoid treating Haskell operators as comments#3707
Open
imwyvern wants to merge 1 commit intosharkdp:masterfrom
Open
fix(syntax): avoid treating Haskell operators as comments#3707imwyvern wants to merge 1 commit intosharkdp:masterfrom
imwyvern wants to merge 1 commit intosharkdp:masterfrom
Conversation
imwyvern
force-pushed
the
clawoss/fix/3694-haskell-operator-comment
branch
from
bfc739f to
8b39d1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Haskell syntax treated any
--sequence as a line comment starter, so legal operators such as-->in fixity declarations were highlighted as comments.This adds a syntax patch matching double-dash comments only when the dash sequence is not followed by another Haskell operator character, while preserving normal comments like
-- textand--foo.Fixes #3694.
Verification:
patch --dry-run --strip=0 -d assets < assets/patches/Haskell.sublime-syntax.patch-- comment,--foo,---,-->, and--->assets/create.shcould not be run in this environment becausebatis not installed on PATH.