Fix LT-22121: Analyze guesser should not guess ras for rAs#327
Merged
Conversation
Contributor
|
For clarity I think you should move this below the first assert. |
Contributor
|
I wouldn't expect a method named HasContextCounts to have significant side-affects, it seems like some clean-up to this section would be good. |
jasonleenaylor
approved these changes
Jun 16, 2025
Contributor
jasonleenaylor
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-22121. In order to handle cases where the occurrence was rAs but the wordform was ras, I changed the code to look up the wordform, the occurrence form, and the occurrence form with the first letter lowercased. These are usually all the same, but in rare cases they can all be different if the user chooses a wordform that isn't the occurrence form or an initial lowercase form of the occurrence form. This needed a lot of changes to the code. This should probably be saved for release/9.3.
This change is