Add SpecificItemAndFieldName() to ISenseOrEntry#337
Conversation
imnasnainaec
left a comment
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion
a discussion (no related file):
Please update the CHANGELOG.
src/SIL.LCModel/InterfaceAdditions.cs line 6009 at r1 (raw file):
/// the value from the specificItem.</param> void SpecificItemAndFieldName(string fieldName, out ICmObject specificItem, out string specificFieldName);
This extra empty line can be removed.
src/SIL.LCModel/DomainImpl/OverridesLing_Lex.cs line 10088 at r1 (raw file):
{ var sense = Item as ILexSense; if (sense != null)
Could condense to if (fieldName == "HeadWordRef" && Item is ILexSense)
src/SIL.LCModel/DomainImpl/OverridesLing_Lex.cs line 10096 at r1 (raw file):
{ var sense = Item as ILexSense; if (sense != null)
Could condense to else if (fieldName == "EntryRefsOS" && Item is ILexSense sense)
Added to support a fix for LT-22124 in Fieldworks.
imnasnainaec
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mark-sil)
Added to support a fix for LT-22124 in Fieldworks.
This change is