Fix LT-21976: Merge dialect labels on duplicated entries in import#343
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where dialect labels were not being properly merged when importing duplicate lexical entries from XML data. The change ensures that when duplicate entries are detected during import, their dialect labels are combined rather than lost.
- Added logic to merge dialect labels from old entries into new entries during import
- Created a test case to verify dialect label merging works correctly with XML import data
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/SIL.LCModel/Application/ApplicationServices/XmlImportData.cs | Added MergeDialectLabels method and integrated it into the entry merging process |
| tests/SIL.LCModel.Tests/Application/ApplicationServices/XmlImportDataTests.cs | Added test case to verify dialect label merging functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…ortDataTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is