Make shared strings public to enable FieldWorks SDK style builds#346
Merged
Conversation
- In the old build system somehow using the same namespace in the FieldWorks code and in this library was enough to get internal access to the strings resources. Update these strings to public so that FieldWorks can use them in its UI.
There was a problem hiding this comment.
Pull Request Overview
This PR makes shared string resources public to enable FieldWorks SDK style builds. The change addresses a compatibility issue where the old build system allowed internal access to string resources through namespace sharing, but this no longer works in the new build system.
Key Changes
- Updated the ResX code generator to produce public string resources instead of internal ones
Files not reviewed (1)
- src/SIL.LCModel.FixData/Strings.Designer.cs: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is