Skip to content

Fix LcmMetaDataCache race condition on static Flid counter #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myieye merged 1 commit into from
May 6, 2026
Merged

Fix LcmMetaDataCache race condition on static Flid counter #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/SIL.LCModel/Infrastructure/Impl/LcmMetaDataCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,25 +69,29 @@ internal sealed class LcmMetaDataCache : IFwMetaDataCacheManaged, IFwMetaDataCac
#endregion Data Members for IFwMetaDataCache Support

#region Construction
private static readonly object s_constructorLock = new object();

/// <summary>
/// Constructor.
/// </summary>
internal LcmMetaDataCache()
{
m_initialized = false;
lock (s_constructorLock)
{
m_initialized = false;

// Reset static counters for attrs.
VirtualPropertyAttribute.ResetFlidCounter();
FieldDescription.ClearDataAbout();
// Reset static counters for attrs.
VirtualPropertyAttribute.ResetFlidCounter();
FieldDescription.ClearDataAbout();

var cmObjectTypesBaseFirst = CmObjectTypesBaseFirst();
var cmObjectTypesBaseFirst = CmObjectTypesBaseFirst();

CmObjectSurrogate.InitializeConstructors(cmObjectTypesBaseFirst);
CmObjectSurrogate.InitializeConstructors(cmObjectTypesBaseFirst);

InitializeMetaDataCache(cmObjectTypesBaseFirst);
InitializeMetaDataCache(cmObjectTypesBaseFirst);

m_initialized = true;
m_initialized = true;
}
}

/// <summary/>
Expand Down
Loading