Skip to content

Store factor to file#4

Open
JKutt wants to merge 7 commits into
simpeg:mainfrom
JKutt:store_factor_to_file
Open

Store factor to file#4
JKutt wants to merge 7 commits into
simpeg:mainfrom
JKutt:store_factor_to_file

Conversation

@JKutt

@JKutt JKutt commented Feb 16, 2022

Copy link
Copy Markdown

Starting pull request for pydiso store factorizations to file and reload

@codecov

codecov Bot commented Apr 5, 2022

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.41860% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.59%. Comparing base (0bfacfa) to head (68ed277).
⚠️ Report is 77 commits behind head on main.

Files with missing lines Patch % Lines
pydiso/mkl_solver.pyx 74.41% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   70.22%   71.59%   +1.36%     
==========================================
  Files           2        2              
  Lines         225      264      +39     
==========================================
+ Hits          158      189      +31     
- Misses         67       75       +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JKutt

JKutt commented Apr 14, 2022

Copy link
Copy Markdown
Author

@jcapriot everything passing! Have a look when you have a moment. The flag files seem a little clunky but for large problems specifically, there needs to be something to flag that the factorization is complete. Certainly open to suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant